-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update wordpress dependencies #855
Conversation
@@ -16,6 +16,7 @@ import { | |||
Spinner, | |||
ToggleControl, | |||
Toolbar, | |||
// eslint-disable-next-line @wordpress/no-unsafe-wp-apis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally we wouldn't import this package, but that's out of scope for this PR
Package-wise it makes sense to me, but I haven't tested the functionality. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update, @noahtallen! Did functional testing for all blocks and didn't see anything unexpected.
🎉 This PR is included in version 1.37.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 1.37.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
All Submissions:
Changes proposed in this Pull Request:
This PR is motivated by our updates to react and wp over at
wp-calypso
(and ETK/wpcom).yarn
really likes all peer dependencies being resolved. :)How to test the changes in this Pull Request:
Other information: